Conversation
…e wizard Move _() translation calls out of return dict literals into local variables. In Odoo 19, _() inspects the call stack to find a valid cursor, which can fail when called inline in a return statement. Also fix test assertions to match actual ir.actions.client return structure instead of ir.actions.act_window.
Add jwcrypto to external_dependencies in both spp_key_management and spp_claim_169 manifests, and to requirements.txt for CI installation. Without this, tests exercising key generation paths fail with "jwcrypto library required for key generation".
…ointers Run prettier on XML data files to fix attribute formatting. Convert three GeoJSON files from raw content to proper Git LFS pointers as specified by .gitattributes.
Summary of ChangesHello @jeremi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical CI failures on the 19.0 branch by implementing several fixes across different modules. The changes primarily focus on ensuring compatibility with Odoo 19's behavior regarding translation calls, resolving missing external dependencies for cryptographic operations, and standardizing data file formatting and storage. These updates are essential for maintaining a stable and functional development environment. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several fixes to resolve CI failures. The changes include moving Odoo translation calls to local variables to prevent call stack issues in Odoo 19, adding the missing jwcrypto dependency to manifests and requirements.txt, and applying consistent formatting to several XML data files. The code changes are correct and well-implemented, particularly the fix for the translation calls which is clearly explained. The test updates accurately reflect the new return structure. The dependency and formatting changes are also appropriate. The pull request is in good shape and addresses the stated goals effectively.
1 participant
Summary
_()translation calls out of return dict literals into local variables — in Odoo 19,_()inspects the call stack for a valid cursor, which fails when called inline in a return statement. Also fix test assertions to match actualir.actions.clientreturn structure.jwcryptotoexternal_dependenciesin both manifests and torequirements.txtfor CI installation. Without this, tests exercising key generation paths fail.Test plan
spp_change_request_v2tests pass (specificallytest_wizard_create_draft_success)spp_mis_demo_v2tests pass (specificallytest_claim169_*tests)